SQL Injection in CubeCart PHP Free & Commercial Shopping Cart Application

Advisory ID Internal
CORE-2010-0415

1. Advisory Information

Title: SQL Injection in CubeCart PHP Free & Commercial Shopping Cart Application
Advisory Id: CORE-2010-0415
Advisory URL: https://www.coresecurity.com/core-labs/advisories/cubecart-php-shopping-cart-sql-injection
Date published: 2010-06-08
Date of last update: 2010-01-01
Vendors contacted: CubeCart
Release mode: Coordinated release

2. Vulnerability Information

Class: SQL injection [CWE-89]
Impact: Code execution
Remotely Exploitable: Yes
Locally Exploitable: No
CVE Name: CVE-2010-1931
Bugtraq ID: N/A

3. Vulnerability Description

There is an SQL Injection[1] vulnerability in the CubeCart PHP Shopping cart[2], this vulnerability may be exploited by HTTP POSTing mailicious data to the index.php script of CubeCart. As an example, exploitation may result in leak of sensitive information or injection of mailicious code into the shopping cart's web page.

4. Vulnerable Packages

  • CubeCart v.4.3.4
  • CubeCart v.4.3.5
  • CubeCart v.4.3.6
  • CubeCart v.4.3.7
  • CubeCart v.4.3.8
  • CubeCart v.4.3.9
  • Older versions are probably affected too, but they were not checked.

5. Non-Vulnerable Packages

  • CubeCart v.4.4.0

6. Vendor Information, Solutions and Workarounds

Upgrade to the latest version of CubeCart, available at CubeCart's web page[1].

7. Credits

This vulnerability was discovered and researched by 7Safe. This advisory was coordinated by Pedro Varangot.

8. Technical Description / Proof of Concept Code

The shipKey parameter of the following POST request (Updating basket) is not adequately sanitized resulting in SQL Injection.

POST /CubeCart/index.php?_g=co&_a=step2 HTTP/1.1 Cookie: [...] Content-Type: application/x-www-form-urlencoded [...] quan%5B3afcdbfeb6ecfbdd0ba628696e3cc163%5D=3&shipKey=1'&coupon= 

This happens because the shipKey is assumed to be of the int datatype, and is not cast nor checked before sent to the database, as we can see in the folling code snippet:

if(isset($_POST['shipKey']) && $_POST['shipKey']>0) { $cart->setVar($_POST['shipKey'],'shipKey'); // lose post vars $refresh = true; }

The following snippet correctly patches this bug:

if(isset($_POST['shipKey']) && (int)$_POST['shipKey']>0) { $cart->setVar((int)$_POST['shipKey'],'shipKey'); // lose post vars $refresh = true; }

9. Report Timeline

  • 2010-06-02: Core Security Technologies contacts the CubeCart team informing an SQL injection vulnerability has been found, and than an advisory draft is ready.
  • 2010-06-02: The CubeCart team asks Core for a technical description of the vulnerability, in the form of an advisory draft, over plaintext e-mail.
  • 2010-06-02: Technical details are sent by Core in the form of a draft of this advisory.
  • 2010-06-03: The CubeCart team replies informing that CubeCart 4.4.0 will be released very soon, and that this vulnerability will be patched in that version.
  • 2010-06-04: CubeCart 4.4.0 is released.
  • 2010-06-08: Advisory CORE-2010-0415 is published.

10. References

[1] http://www.owasp.org/index.php/SQL_Injection
[2] http://www.cubecart.com/

11. About CoreLabs

CoreLabs, the research center of Core Security, A HelpSystems Company is charged with researching and understanding security trends as well as anticipating the future requirements of information security technologies. CoreLabs studies cybersecurity trends, focusing on problem formalization, identification of vulnerabilities, novel solutions, and prototypes for new technologies. The team is comprised of seasoned researchers who regularly discover and discloses vulnerabilities, informing product owners in order to ensure a fix can be released efficiently, and that customers are informed as soon as possible. CoreLabs regularly publishes security advisories, technical papers, project information, and shared software tools for public use at https://www.coresecurity.com/core-labs.  

12. About Core Security, A HelpSystems Company

Core Security, a HelpSystems Company, provides organizations with critical, actionable insight about who, how, and what is vulnerable in their IT environment. With our layered security approach and robust threat-aware, identity & access, network security, and vulnerability management solutions, security teams can efficiently manage security risks across the enterprise. Learn more at www.coresecurity.com.

Core Security is headquartered in the USA with offices and operations in South America, Europe, Middle East and Asia. To learn more, contact Core Security at (678) 304-4500 or info@helpsystems.com.

13. Disclaimer

The contents of this advisory are copyright (c) 2010 Core Security Technologies and (c) 2010 CoreLabs, and may be distributed freely provided that no fee is charged for this distribution and proper credit is given.

14. PGP/GPG Keys

This advisory has been signed with the GPG key of Core Security advisories team.